[ovs-dev] [PATCH 1/2] datapath: Send to userspace errors shouldn't halt processing.
jesse at nicira.com
Wed Sep 21 10:24:47 PDT 2011
On Wed, Sep 21, 2011 at 9:05 AM, Ben Pfaff <blp at nicira.com> wrote:
> On Tue, Sep 20, 2011 at 05:00:26PM -0700, Jesse Gross wrote:
>> If we encounter an error when sending a packet to userspace due to
>> an explicit action we stop processing further actions. This makes
>> sense for things like push vlan, where to continue means outputting
>> an incorrect packet. However, sending to userspace is more akin
>> to outputting to a port, which does not halt further processing.
>> For consistency, ignore errors in this case as well.
>> Signed-off-by: Jesse Gross <jesse at nicira.com>
> I'd consider making output_userspace() a void function also, since its
> return value is always ignored.
I guess I don't like hiding errors at an intermediate point - it seems
better to do it at the "ultimate" user of the function, so that it's
clear that it can return an error and we're ignoring it.
> Acked-by: Ben Pfaff <blp at nicira.com>
Thanks, I pushed these two patches.
More information about the dev