[ovs-dev] [vlans 5/5] Implement "native VLAN" feature.

Ben Pfaff blp at nicira.com
Wed Sep 21 14:37:57 PDT 2011


On Wed, Sep 21, 2011 at 01:17:16PM -0700, Ethan Jackson wrote:
> The comments in set_dst need reformating.  They have redundant blank lines in
> the beginining of the comment.  They need to capitolize sentences and use
> periods.  The ending "*/" needs to join with the last line if possible, etc.
> 
> +            802.1Q header.  A packet that egresses on a trunk port, it will
> port, it will => port will

Thanks, I applied those changes.

When I reran the tests, however, I found that we have regressions from
1.2.x in this area.

I also discovered that mirroring doesn't work with this new feature
properly.

I'm going to work on these problems, then I'll post the fix.



More information about the dev mailing list