[ovs-dev] [PATCH v4] Genericize/simplify kernel sFlow implementation

[Ben Pfaff]

On Wed, Sep 28, 2011 at 12:52:08AM -0700, Jesse Gross wrote:
> On Tue, Sep 27, 2011 at 4:56 PM, Pravin Shelar <pshelar at nicira.com> wrote:
> > This is incremental patch to sFlow patch posted. Fixed according to
> > comments from Jesse.
> > ?? ?? ?? ?? - Fixed use-after-free bug in sample()
> > ?? ?? ?? ?? - Fixed comments
> > ?? ?? ?? ?? - Controller generated packets at undefined in_port are not
> > ?? ?? ?? ?? ?? sampled
> >
> > Signed-off-by: Pravin Shelar <pshelar at nicira.com>
> 
> Thanks, these changes look good to me.  Ben, do you have any further comments?

In parse_odp_packet(), I think that we can remove OVS_PACKET_ATTR_ACTIONS
from the policy, because it won't appear in messages sent from the kernel
to userspace (right?).  At any rate parse_odp_packet() never uses it.

dpif_sflow_get_probability() should return a uint32_t, not an int.

I don't need to see an updated patch.