[ovs-dev] [PATCH] unixctl.py: Allow callers to manually set unixctl version.
ethan at nicira.com
Mon Apr 2 13:11:34 PDT 2012
I added this paragraph as a docstring to the create command:
"""Creates a new UnixctlServer which listens on a unixctl socket
created at 'path'. If 'path' is None, the default path is chosen.
'version' contains the version of the server as reported by the unixctl
version command. If None, ovs.version.VERSION is used."""
I'll merge this shortly, thanks for the review.
On Mon, Apr 2, 2012 at 12:33, Ben Pfaff <blp at nicira.com> wrote:
> On Fri, Mar 30, 2012 at 11:47:52PM -0700, Ethan Jackson wrote:
>> Some clients of unixctl.py may want to use a different version than
>> the one supplied in ovs.version.VERSION. This patch supports an
>> optional manual override of this value.
>> Feature #10383.
>> Signed-off-by: Ethan Jackson <ethan at nicira.com>
> Could you add a docstring to UnixctlServer.create() that explains
> Otherwise this look good to me, thank you.
More information about the dev