[ovs-dev] [PATCH 3/3] datapath: Release rtnl_lock if ovs_vport_cmd_build_info() failed

Ansis Atteka aatteka at nicira.com
Fri Apr 6 18:07:58 PDT 2012


This patch fixes a possible lock-up bug where rtnl_lock might not
get released.

Signed-off-by: Ansis Atteka <aatteka at nicira.com>
---
 datapath/datapath.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/datapath/datapath.c b/datapath/datapath.c
index 2fe6fdd..76f7a2c 100644
--- a/datapath/datapath.c
+++ b/datapath/datapath.c
@@ -1894,7 +1894,8 @@ static int ovs_vport_cmd_set(struct sk_buff *skb, struct genl_info *info)
 		err = PTR_ERR(reply);
 		netlink_set_err(GENL_SOCK(sock_net(skb->sk)), 0,
 				ovs_dp_vport_multicast_group.id, err);
-		return 0;
+		err = 0;
+		goto exit_unlock;
 	}
 
 	genl_notify(reply, genl_info_net(info), info->snd_pid,
-- 
1.7.9.1




More information about the dev mailing list