[ovs-dev] [PATCH 3/3] datapath: Release rtnl_lock if ovs_vport_cmd_build_info() failed

[Jesse Gross]

On Fri, Apr 6, 2012 at 6:07 PM, Ansis Atteka <aatteka at nicira.com> wrote:
> This patch fixes a possible lock-up bug where rtnl_lock might not
> get released.
>
> Signed-off-by: Ansis Atteka <aatteka at nicira.com>

I think there's still an issue in this code path (although not a new
one).  If ovs_vport_set_options() succeeds but change_vport() and
ovs_vport_cmd_build_info() fail then we should both set an error
status on the netlink socket and return an error.  This will end up
doing the former but not the latter.