[ovs-dev] [PATCH 2/2] stream: By default disable probing on unix sockets.

Ben Pfaff blp at nicira.com
Fri Apr 13 16:02:33 PDT 2012


On Wed, Apr 11, 2012 at 10:02:10PM -0700, Ethan Jackson wrote:
> There isn't a lot of value in sending inactivity probes on unix
> sockets.  This patch changes the default to disable them.
> 
> Signed-off-by: Ethan Jackson <ethan at nicira.com>

I'm half-inclined to just write a single function that can take either
a stream or pstream name.  It could return -1 if it's not valid for
either, 0 if probes aren't needed, 1 if they are.  Then you could just
use one function call, something like "if (!probes_needed(name))
interval = 0;".

Something tells me you didn't test this assertion:
> +        assert name.statswith("punix:")

Should we update any documentation or NEWS?

Thanks,

Ben.



More information about the dev mailing list