[ovs-dev] [PATCH 2/2] [RFC] Add OXM data to mf_fields

Simon Horman horms at verge.net.au
Tue Apr 24 17:20:10 PDT 2012


On Tue, Apr 24, 2012 at 09:14:40AM -0700, Ben Pfaff wrote:
> On Tue, Apr 24, 2012 at 10:32:55AM +0900, Simon Horman wrote:
> > Add oxm_name and oxm_header elements to struct mf_field
> > and populate those entries for fields that are present
> > in both NXM and the OXM basic class.
> > 
> > This implementation was suggested by Ben Pfaff.
> > 
> > This does not address any possible differences in the NXM and
> > OXM basic class fields, for instance different maskability.
> > That may be addressed later as needed.
> > 
> > Signed-off-by: Simon Horman <horms at verge.net.au>
> 
> Seems reasonable.
> 
> I think that there are also some semantic differences between the VLAN
> VID field that we implement currently, which is based on OF1.0, and
> the VLAN VID field in OF1.2.  I'm not sure how we should deal with
> those.

I expect that there are a few such differences between OXM and the current
implementation. My plan is to get code in place to the point where we can
start sending messages. Code that as much as possible uses the existing
implementation. Then to focus on the corner cases.

As you may have noticed, part of my plan is to get patches out as they
are done rather than waiting to have a complete working implementation.
Primarily this is for review; so I can get feedback along the way; and so
you don't get overloaded by a huge patchset later on.

I do expect to have to go back and fix things up as the implementation
progresses.

> 
> I think I'm OK with committing (the second version of) this once
> you've revised the first patch to make sure the field widths are
> correct.

Thanks, I'll send some updates.



More information about the dev mailing list