[ovs-dev] [PATCH 2/2] ofp-util: Treat a packet-out in_port of OFPP_CONTROLLER as OFPP_NONE.

Ethan Jackson ethan at nicira.com
Mon Apr 30 14:53:16 PDT 2012


> +    if (po->in_port == OFPP_CONTROLLER) {
> +        /* The OpenFlow 1.0 spec says OFPP_NONE is the correct in_port for a
> +         * packet generated by the controller, but a lot of controllers
> +         * mistakenly use OFPP_CONTROLLER instead.  Fix it up for them. */
> +        po->in_port = OFPP_NONE;

My only question with this patch is whether we should be setting the
in_port to OFPP_NONE, or letting it go through with an in_port of
OFPP_CONTROLLER.  Assuming a controller mistakenly uses
OFPP_CONTROLLER as its in_port, I would think that it would reasonably
assume that if it wanted to match on packets coming from itself, it
would match on OFPP_CONTROLLER as the in_port.  Thoughts on this?

Looks good,
Ethan



More information about the dev mailing list