[ovs-dev] [async-msgs 01/13] ofproto: Allow service controllers to become masters and slaves.

[Ethan Jackson]

Seems fine to me.

Ethan

On Thu, Jan 26, 2012 at 15:53, Ben Pfaff <blp at nicira.com> wrote:

> I don't remember why we disallow this.  It seems reasonable to me to enable
> it.  A test in a upcoming commit relies upon the ability.
>
> Signed-off-by: Ben Pfaff <blp at nicira.com>
> ---
>  ofproto/ofproto.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
> index 7fa4eac..c78aa39 100644
> --- a/ofproto/ofproto.c
> +++ b/ofproto/ofproto.c
> @@ -2814,10 +2814,6 @@ handle_role_request(struct ofconn *ofconn, const
> struct ofp_header *oh)
>     struct ofpbuf *buf;
>     uint32_t role;
>
> -    if (ofconn_get_type(ofconn) != OFCONN_PRIMARY) {
> -        return OFPERR_OFPBRC_EPERM;
> -    }
> -
>     role = ntohl(nrr->role);
>     if (role != NX_ROLE_OTHER && role != NX_ROLE_MASTER
>         && role != NX_ROLE_SLAVE) {
> --
> 1.7.2.5
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://openvswitch.org/pipermail/dev/attachments/20120203/53d1c845/attachment.htm>