[ovs-dev] [PATCH 2/2] netdev-linux: Cache flags using netlink.

Ben Pfaff blp at nicira.com
Tue Feb 14 13:41:06 PST 2012


On Mon, Feb 13, 2012 at 07:07:32PM -0800, Ethan Jackson wrote:
> Before this patch, every request for a 'netdev_dev''s flags
> required an ioctl call.  This occurred every time
> netdev_get_carrier() was called, which theoretically was very often
> if there were a large number of devices.  We were already using
> netlink to keep track of the IFF_RUNNING flag. This patch
> generalizes the code to keep track of all flags using the same
> netlink code.
> 
> Signed-off-by: Ethan Jackson <ethan at nicira.com>

Looks good to me.  Thank you!

Only comment is that I think "unsigned int" is better for ifi_flags.

Thanks,

Ben.



More information about the dev mailing list