[ovs-dev] [PATCH 2/2] xenserver: Restart ovs-xapi-sync on kmod reload.

Ben Pfaff blp at nicira.com
Wed Feb 29 19:53:06 PST 2012


On Wed, Feb 29, 2012 at 07:17:25PM -0800, Ethan Jackson wrote:
> Some users never restart OVS, they just reload the kernel module on
> each new version. Since ovs-xapi-sync is a daemon, a restart is
> required to use the new code.  Therefore, without this patch, users
> could unwittingly use stale versions of ovs-xapi-sync.
> 
> Bug #9919.
> Signed-off-by: Ethan Jackson <ethan at nicira.com>

Looks good, except that I would change this:
> +    if daemon_is_running ovs-xapi-sync; then
> +        action "Stopping ovs-xapi-sync" stop_daemon ovs-xapi-sync
> +    fi
to just:
        stop_daemon ovs-xapi-sync
because stop_daemon already prints everything that is needed.

Thanks,

Ben.



More information about the dev mailing list