[ovs-dev] [dpif-logging 3/3] dpif: Log each operation in dpif_operate().

Ben Pfaff blp at nicira.com
Mon Jan 16 13:39:11 PST 2012


Thank you for the reviews.  I pushed this series to master.

On Mon, Jan 16, 2012 at 01:31:04PM -0800, Ethan Jackson wrote:
> Looks good,
> 
> Ethan
> 
> On Tue, Dec 27, 2011 at 13:23, Ben Pfaff <blp at nicira.com> wrote:
> > Without logging of operation groups, it becomes more difficult to debug
> > problems related to flow setups, since those go through operation groups.
> >
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> > ---
> > ?lib/dpif.c | ? 14 ++++++++++++++
> > ?1 files changed, 14 insertions(+), 0 deletions(-)
> >
> > diff --git a/lib/dpif.c b/lib/dpif.c
> > index 3ec83a2..54a5d4e 100644
> > --- a/lib/dpif.c
> > +++ b/lib/dpif.c
> > @@ -991,6 +991,20 @@ dpif_operate(struct dpif *dpif, struct dpif_op **ops, size_t n_ops)
> >
> > ? ? if (dpif->dpif_class->operate) {
> > ? ? ? ? dpif->dpif_class->operate(dpif, ops, n_ops);
> > +
> > + ? ? ? ?for (i = 0; i < n_ops; i++) {
> > + ? ? ? ? ? ?struct dpif_op *op = ops[i];
> > +
> > + ? ? ? ? ? ?switch (op->type) {
> > + ? ? ? ? ? ?case DPIF_OP_FLOW_PUT:
> > + ? ? ? ? ? ? ? ?log_flow_put_message(dpif, &op->u.flow_put, op->error);
> > + ? ? ? ? ? ? ? ?break;
> > +
> > + ? ? ? ? ? ?case DPIF_OP_EXECUTE:
> > + ? ? ? ? ? ? ? ?log_execute_message(dpif, &op->u.execute, op->error);
> > + ? ? ? ? ? ? ? ?break;
> > + ? ? ? ? ? ?}
> > + ? ? ? ?}
> > ? ? ? ? return;
> > ? ? }
> >
> > --
> > 1.7.2.5
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev



More information about the dev mailing list