[ovs-dev] [PATCH] cfm: Log more aggressively amidst packet loss.
blp at nicira.com
Mon Jan 23 15:17:30 PST 2012
On Mon, Jan 23, 2012 at 03:16:00PM -0800, Ethan Jackson wrote:
> > Please add Jacob to AUTHORS.
> > This adds an odd blank line near the end of cfm_run().
> > The current message reports missing sequence numbers, but I think that
> > there are at least two other possible issues: duplicate sequence
> > numbers and out-of-order sequence numbers. It might be a good idea
> > either to detect and report these with separate messages (based on
> > whether the new sequence number is greater than, less than, or equal
> > to the previous number), or to make the single message make a less
> > specific claim about the problem.
> I changed the warning message to the following. I'd prefer to avoid
> trying to guess the exact reason for the sequence number anomalies.
> + VLOG_WARN_RL(&rl, "%s: (mpid %"PRIu64") detected sequence"
> + " numbers which indicate possible connectivity"
> + " problems (previous %"PRIu32") (current %"PRIu32
> + ")", cfm->name, ccm_mpid, rmp->seq, ccm_seq);
Thanks. Sounds fine to me.
More information about the dev