[ovs-dev] [PATCH] packets: Use RARPs for learning packets.
blp at nicira.com
Thu Jun 7 16:52:18 PDT 2012
On Thu, Jun 07, 2012 at 07:50:02PM -0400, Ben Pfaff wrote:
> On Thu, Jun 07, 2012 at 04:17:18PM -0700, Ethan Jackson wrote:
> > Traditionally Open vSwitch had used 802.2 SNAP packets to update
> > upstream switch learning tables when necessary. This approach had
> > advantages in that debugging information could be embedded in the
> > packet helping hapless admins figure out what's going on. However,
> > since both qemu and VMware use RARP for this purpose, it seems
> > appropriate to fall in line with the defacto standard.
> > Requested-by: Ben Basler <bbasler at nicira.com>
> > Signed-off-by: Ethan Jackson <ethan at nicira.com>
> The use of "us" in NEWS is a bit more informal than usual. Perhaps:
> - Open vSwitch now sends RARP packets in situations where it
> previously sent a custom protocol, consistent with behavior of
> QEMU and VMware.
> Why are src_proto_addr and target_proto_addr byte arrays instead of
> "ovs_be32"s? (The struct is marked "packed".)
Also, did you look at the RARP packets that this sends in tcpdump or
wireshark, to make sure that they have the correct format?
More information about the dev