[ovs-dev] [PATCH] tests: Add $(check_DATA) to check-valgrind dependencies.

Ben Pfaff blp at nicira.com
Wed Jun 13 13:26:27 PDT 2012


Otherwise if you run "check-valgrind" in a tree where you've never run
"check", you get some test failures because some data files don't get
generated before the tests run.

Signed-off-by: Ben Pfaff <blp at nicira.com>
---
 tests/automake.mk |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/tests/automake.mk b/tests/automake.mk
index 784ae9c..3f440e0 100644
--- a/tests/automake.mk
+++ b/tests/automake.mk
@@ -192,7 +192,8 @@ VALGRIND = valgrind --log-file=valgrind.%p --leak-check=full \
 	--suppressions=$(abs_top_srcdir)/tests/glibc.supp \
 	--suppressions=$(abs_top_srcdir)/tests/openssl.supp --num-callers=20
 EXTRA_DIST += tests/glibc.supp tests/openssl.supp
-check-valgrind: all tests/atconfig tests/atlocal $(TESTSUITE) $(valgrind_wrappers)
+check-valgrind: all tests/atconfig tests/atlocal $(TESTSUITE) \
+                $(valgrind_wrappers) $(check_DATA)
 	$(SHELL) '$(TESTSUITE)' -C tests CHECK_VALGRIND=true VALGRIND='$(VALGRIND)' AUTOTEST_PATH='tests/valgrind:$(AUTOTEST_PATH)' -d $(TESTSUITEFLAGS)
 	@echo
 	@echo '----------------------------------------------------------------------'
-- 
1.7.2.5




More information about the dev mailing list