[ovs-dev] [PATCH 04/19] Add oputil_of12_put_match()
horms at verge.net.au
Thu Jun 14 18:00:00 PDT 2012
On Thu, Jun 14, 2012 at 08:43:58AM -0700, Ben Pfaff wrote:
> On Thu, Jun 14, 2012 at 07:31:03PM +0900, Simon Horman wrote:
> > On Thu, Jun 14, 2012 at 06:12:18PM +0900, Simon Horman wrote:
> > > On Wed, Jun 13, 2012 at 11:12:59PM -0700, Ben Pfaff wrote:
> > > > On Thu, Jun 14, 2012 at 08:51:52AM +0900, Simon Horman wrote:
> > > > > Signed-off-by: Simon Horman <horms at verge.net.au>
> > > >
> > > > s/oputil/ofputil/
> > > >
> > > > I'd be happier to have a more generic function: one that accepted a
> > > > "protocol" parameter and used the correct match type based on the
> > > > protocol. Not a big deal to factor that in later, though, I guess.
> > >
> > > Sure, something like the following?
> > Sorry, that was a bit bogus. I think the following is better.
> Yes, I like that better.
> You can't keep the 'omh' pointer across the nx_put_match() call because
> nx_put_match() may reallocate the buffer's data. You have to reload it,
> e.g. as an offset from msg->data.
Thanks, I have fixed that now.
More information about the dev