[ovs-dev] [PATCH 05/25] ofp-actions: Support encoding OpenFlow 1.1 instructions and actions.
blp at nicira.com
Thu Jun 14 23:36:47 PDT 2012
On Thu, Jun 14, 2012 at 10:02:26PM -0700, Ben Pfaff wrote:
> On Thu, Jun 14, 2012 at 07:43:17PM +0900, Simon Horman wrote:
> > I am unsure about what to do about some of the messages,
> > as noted with 'FIXME' in the code.
> > Signed-off-by: Simon Horman <horms at verge.net.au>
> I think that this has a conceptual flaw. Most places in OpenFlow 1.1+,
> we need to actions appear only encapsulated inside instructions
> (Apply-Actions or Write-Actions), although ofp_packet_out and ofp_bucket
> do contain raw actions. The code I posted before works that out on the
> decoding side, but I don't see how you're planning to work it out on the
> encoding side. It looks like you're just encoding the raw actions,
> without encapsulating them into instruction.
> I'm looking at actions and instructions at the moment, perhaps I'll fix
> this up.
I put this patch plus updates into the second version of my "of1.1
rollup" series, starting here:
More information about the dev