[ovs-dev] [PATCH] ovs-lib: Add time stamps to Valgrind log messages.
Ben Pfaff
blp at nicira.com
Wed Jun 20 14:30:47 PDT 2012
Thanks, pushed to master.
On Wed, Jun 20, 2012 at 01:43:33PM -0700, Justin Pettit wrote:
> Looks good.
>
> --Justin
>
>
> On Jun 20, 2012, at 10:29 AM, Ben Pfaff wrote:
>
> > Sometimes it's easier to interpret Valgrind warnings when you can
> > correlate them with other events.
> >
> > Suggested-by: James Schmidt <jschmidt at nicira.com>
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> > ---
> > utilities/ovs-lib.in | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/utilities/ovs-lib.in b/utilities/ovs-lib.in
> > index 50a5950..f8e2609 100644
> > --- a/utilities/ovs-lib.in
> > +++ b/utilities/ovs-lib.in
> > @@ -110,7 +110,7 @@ start_daemon () {
> > case $wrapper in
> > valgrind)
> > if (valgrind --version) > /dev/null 2>&1; then
> > - set valgrind -q --leak-check=full \
> > + set valgrind -q --leak-check=full --time-stamp=yes \
> > --log-file="$logdir/$daemon.valgrind.log.%p" "$@"
> > else
> > log_failure_msg "valgrind not installed, running $daemon without it"
> > --
> > 1.7.2.5
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
>
More information about the dev
mailing list