[ovs-dev] [PATCH 2/3] bridge: Run fast when adding and deleting ports.
blp at nicira.com
Fri Jun 22 14:37:31 PDT 2012
It seems to open up a short race window between adding the port to the
ofproto and configuring the port, in which a packet received on the
port would trigger the warning "received packet on unknown port" in
lookup_input_bundle(). I guess we could configure the port earlier or
suppress the message somehow.
I don't see an actual problem though.
On Fri, Jun 22, 2012 at 11:23:52AM -0700, Ethan Jackson wrote:
> The data structures which we care about are: The all_bridges list and
> br->ofproto in each bridge. I admit that this feels a bit fragile. I
> think the correct solution is to move expensive stuff into the worker
> process so this sort of thing isn't necessary. Perhaps we could get
> rid of the run_fast hooks all together. For now though I don't think
> this patch will cause problems.
> On Fri, Jun 22, 2012 at 9:09 AM, Ben Pfaff <blp at nicira.com> wrote:
> > On Thu, Jun 21, 2012 at 06:51:34PM -0700, Ethan Jackson wrote:
> >> Adding and deleting ports can be extremely expensive so it makes
> >> sense to get important work done before and after doing it.
> >> Signed-off-by: Ethan Jackson <ethan at nicira.com>
> > Are you sure that the bridge data structures are in a consistent state
> > at all of these points?
More information about the dev