[ovs-dev] [bug 10184 2/5] ofproto-dpif: Fix return type of rule_calculate_tag().

[Ethan Jackson]

Looks good.

Ethan

On Tue, Mar 20, 2012 at 15:44, Ben Pfaff <blp at nicira.com> wrote:
> tag_type is currently uint32_t but using uint32_t directly is conceptually
> wrong.
> ---
>  ofproto/ofproto-dpif.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
> index 642e3b0..200846b 100644
> --- a/ofproto/ofproto-dpif.c
> +++ b/ofproto/ofproto-dpif.c
> @@ -109,7 +109,7 @@ static void flow_push_stats(struct rule_dpif *, const struct flow *,
>                             uint64_t packets, uint64_t bytes,
>                             long long int used);
>
> -static uint32_t rule_calculate_tag(const struct flow *,
> +static tag_type rule_calculate_tag(const struct flow *,
>                                    const struct flow_wildcards *,
>                                    uint32_t basis);
>  static void rule_invalidate(const struct rule_dpif *);
> @@ -5694,7 +5694,7 @@ xlate_normal(struct action_xlate_ctx *ctx)
>
>  /* Calculates the tag to use for 'flow' and wildcards 'wc' when it is inserted
>  * into an OpenFlow table with the given 'basis'. */
> -static uint32_t
> +static tag_type
>  rule_calculate_tag(const struct flow *flow, const struct flow_wildcards *wc,
>                    uint32_t secret)
>  {
> --
> 1.7.2.5
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev