[ovs-dev] [PATCH] ovs-bugtool: Add ability to prioritize files by date.

Ben Pfaff blp at nicira.com
Fri Mar 23 14:39:49 PDT 2012


That's fine with.  Omitting such files would also be fine, I guess.
But the new behavior appeared, at a glance, to be that we don't catch
exceptions in os.stat() at all.  No?

On Fri, Mar 23, 2012 at 02:37:21PM -0700, Raju Subramanian wrote:
> The old behaviour was if os.stat() failed, it would still add the file to
> the report but just wouldn't update the counter tracking the sizes. Do you
> want to maintain this behaviour?
> 
> On Fri, Mar 23, 2012 at 2:26 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > On Fri, Mar 23, 2012 at 02:22:23PM -0700, Raju Subramanian wrote:
> > > When size limit is reached in the middle of processing a dir,
> > > the report ends up containing oldest files. This change adds
> > > an optional param in the plugin to prioritize newer files.
> > >
> > > Feature #9937
> > > Requested-by: Ronald Lee <rlee at nicira.com>
> > > Signed-off-by: Raju Subramanian <rsubramanian at nicira.com>
> >
> > The new version still doesn't catch exceptions in os.stat.
> >
> > Thanks,
> >
> > Ben.
> >



More information about the dev mailing list