[ovs-discuss] Bad OpenFlow buffer IDs, etc.

Ben Pfaff blp at nicira.com
Tue Oct 18 14:01:25 PDT 2011


On Mon, Oct 17, 2011 at 12:38:17PM -0700, Murphy McCauley wrote:
> The problem with buffer IDs is in ofputil_encode_packet_in() which
> writes to an unaligned ofp_packet_in pointer.
> 
> Any thoughts on a good way to fix this, or how to locate other places
> where the same thing may be happening (there's no warning or anything)?

The fix itself is easy.  I've appended my first thought at how to do
it.  Please test it and let me know the results.

As for how to locate other places, I don't have good ideas.  Probably,
testing on platforms that signal misaligned accesses (such as SPARC)
instead of on platforms that rotate bytes on misaligned accesses (only
ARM, as far as I know), is a good idea.  Static analysis is better,
but I don't have a good way to do it.

--8<--------------------------cut here-------------------------->8--



More information about the discuss mailing list