[ovs-discuss] (no subject)

[Chris Wright]

* Srinivasa R Kanduru (skanduru at gmail.com) wrote:
> The physical interface is a wireless NIC. I assume that shouldn't have any
> bearing on the behaviour.

Yes, it does.  Seems that OVS ought to do something like:

Subject: [PATCH] openvswitch: honour IFF_DONT_BRIDGE
From: Chris Wright <chrisw at sous-sol.org>

Especially in the case of wireless, the netdev may not work properly.
So honor IFF_DONT_BRIDGE.

Signed-off-by: Chris Wright <chrisw at sous-sol.org>
--
NOTE:  Completely untested

diff --git a/net/openvswitch/vport-netdev.c b/net/openvswitch/vport-netdev.c
index c1068ae..ee04d44 100644
--- a/net/openvswitch/vport-netdev.c
+++ b/net/openvswitch/vport-netdev.c
@@ -96,6 +96,11 @@ static struct vport *netdev_create(const struct vport_parms *parms)
 		goto error_put;
 	}
 
+	if (netdev_vport->dev->priv_flags & IFF_DONT_BRIDGE) {
+		err = -EOPNOTSUPP;
+		goto error_put;
+	}
+
 	err = netdev_rx_handler_register(netdev_vport->dev, netdev_frame_hook,
 					 vport);
 	if (err)