[ovs-git] Open vSwitch: dpif: Make dpif_class 'open' function take class instead of type name. (master)

[dev at openvswitch.org]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  4a38774146f0171a09d5cb1863595b3b546c766e (commit)
       via  d2d8fbebb86eb682fc9507a884e80ff5e6086f03 (commit)
       via  2081be2197e2df6a0612f262407dcca4b837480d (commit)
       via  a3384bc1e50d3b75e25fb6e78a12fc60e5dad324 (commit)
       via  44381c1b4e01d051a8cc9ffccb8c37a0c2d4c808 (commit)
       via  72fae175990e9a4732ba4d368946f3854e994075 (commit)
       via  eb5f3e933b0922d369ad839b2afa1cd7ab764b6e (commit)
       via  e94b92baf63322117e22a7432e1740afa3073587 (commit)
      from  6d37aaf186c9f4595258903241f4fa0175ecf6dd (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4a38774146f0171a09d5cb1863595b3b546c766e
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=4a38774146f0171a09d5cb1863595b3b546c766e
Author: Ben Pfaff <blp at nicira.com>
		
dpif: Make dpif_class 'open' function take class instead of type name.
		
This makes it easier for dpif_provider implementations to share code but
distinguish the class actually in use, because comparing a pointer is
easier than comparing a string.


commit d2d8fbebb86eb682fc9507a884e80ff5e6086f03
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=d2d8fbebb86eb682fc9507a884e80ff5e6086f03
Author: Ben Pfaff <blp at nicira.com>
		
dpif: Use caller-provided dpif_class in dp_register_provider().
		
I don't see a reason here to copy the dpif_class instead of using the
pointer provided by the caller.  Using the caller's pointer allows the
caller to compare a dpif's 'class' member against the address of its
class structure, which seems like a reasonable thing to do.


commit 2081be2197e2df6a0612f262407dcca4b837480d
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=2081be2197e2df6a0612f262407dcca4b837480d
Author: Ben Pfaff <blp at nicira.com>
		
lib: Remove redundant dhparams.h from EXTRA_DIST.
		
This is redundant since it's also in lib_libopenvswitch_a_SOURCES.

Also, remove duplicate blank line.


commit a3384bc1e50d3b75e25fb6e78a12fc60e5dad324
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=a3384bc1e50d3b75e25fb6e78a12fc60e5dad324
Author: Ben Pfaff <blp at nicira.com>
		
netdev-vport: Remove OVS_UNUSED from argument that is actually used.
		


commit 44381c1b4e01d051a8cc9ffccb8c37a0c2d4c808
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=44381c1b4e01d051a8cc9ffccb8c37a0c2d4c808
Author: Ben Pfaff <blp at nicira.com>
		
ofp-util: Consistently treat OpenFlow xids as network byte order.
		
The 'xid' in an ofp_header is not interpreted by the receiver but only by
the sender, so it need not be in any particular byte order.  OVS used to
try to take advantage of this to avoid host/network byte order conversions
for this field.  Older code in OVS, therefore, treats xid as being in host
byte order.  However, as time went on, I forgot that I had introduced this
trick, and so newer code treats xid as being in network byte order.

This commit fixes up the situation by consistently treating xid as being
in network byte order.  I think that this will be less surprising and
easier to remember in the future.

This doesn't fix any actual bugs except that some log messages would have
printed xids in the wrong byte order.


commit 72fae175990e9a4732ba4d368946f3854e994075
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=72fae175990e9a4732ba4d368946f3854e994075
Author: Ben Pfaff <blp at nicira.com>
		
ofp-util: Use a counter for transaction IDs instead of a random number.
		
I don't know of any reason why the transaction id should be random.  Using
consecutive ids means that there is no chance that two messages sent around
the same time will have the same transaction ID, which is probabilitically
possible with random IDs.


commit eb5f3e933b0922d369ad839b2afa1cd7ab764b6e
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=eb5f3e933b0922d369ad839b2afa1cd7ab764b6e
Author: Ben Pfaff <blp at nicira.com>
		
netdev-vport: Fix poll_add() implementation.
		
The existing implementation never worked because it used different strings
for notifier shash addition and lookup: for adding to the shash, it used
the vport name; for lookup, it used "<type>:<name>".  This fixes the
problem, by using "<type>:<name>" in both cases.


commit e94b92baf63322117e22a7432e1740afa3073587
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=e94b92baf63322117e22a7432e1740afa3073587
Author: Ben Pfaff <blp at nicira.com>
		
ovs-ofctl: Fix return value of str_to_port_no().
		
The index into the array of ports returned in the OFPT_FEATURES_REPLY
message is not necessarily the same as the port number, so this fixes a
real bug.


-----------------------------------------------------------------------

Summary of changes:
 lib/automake.mk       |    4 +---
 lib/dpif-linux.c      |    4 ++--
 lib/dpif-netdev.c     |    4 ++--
 lib/dpif-provider.h   |   13 +++++++------
 lib/dpif.c            |   21 +++++++++++----------
 lib/netdev-vport.c    |    6 ++----
 lib/ofp-print.c       |    2 +-
 lib/ofp-util.c        |   18 +++++++++---------
 lib/ofp-util.h        |    7 ++++---
 lib/vconn.c           |    3 ++-
 utilities/ovs-ofctl.c |    6 +++---
 11 files changed, 44 insertions(+), 44 deletions(-)


hooks/post-receive
-- 
Open vSwitch