[ovs-git] Open vSwitch: packet: Match userspace and kernel definition of ICMP header. (master)

dev at openvswitch.org dev at openvswitch.org
Tue Dec 27 11:13:59 PST 2011


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  c4ccff78ec5bad2b602ae72e283960ec393661fe (commit)
      from  deedf7e78b249383d6f7b385f9d04e08e33d0e3f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c4ccff78ec5bad2b602ae72e283960ec393661fe
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=c4ccff78ec5bad2b602ae72e283960ec393661fe
Author: Jesse Gross <jesse at nicira.com>
		
packet: Match userspace and kernel definition of ICMP header.
		
Current userspace considers an ICMP header to be 4 bytes consisting
of the type, code, and checksum.  The kernel considers it to be 8
bytes because it also counts the two data fields that contain
type-specific information (and are always present).  Since flow
extract will zero out headers that are not completely present this
means that an ICMP packet that has a header of 5-7 bytes will be
interpreted differently by userspace and kernel.  This fixes the
problem by adopting the kernel's version of the ICMP header in
userspace.

Signed-off-by: Jesse Gross <jesse at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/packets.h |   14 +++++++++++++-
 1 files changed, 13 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Open vSwitch


More information about the git mailing list