[ovs-git] Open vSwitch: netdev-port: Fix invalid memory access in netdev_vport_poll_add(). (master)

dev at openvswitch.org dev at openvswitch.org
Fri Mar 4 13:58:16 PST 2011


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  0574f71b4b6820cecb8247a6e0269606c8ef2edf (commit)
      from  0cf59c05593ecb078fb3a284ea39f473e0b13364 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0574f71b4b6820cecb8247a6e0269606c8ef2edf
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=0574f71b4b6820cecb8247a6e0269606c8ef2edf
Author: Ben Pfaff <blp at nicira.com>
		
netdev-port: Fix invalid memory access in netdev_vport_poll_add().
		
shash_find_data() returns an shash_node's 'data' member, but this code here
wants the shash_node itself, so it needs to use shash_find() instead.

This bug meant that any attempt to add a single netdev_vport to more than
one netdev_monitor would cause a segmentation fault.  Here's an example
command that reproduces it reliably for me under valgrind (because ofproto
always monitors its ports and the bridge monitors bond interfaces):

ovs-vsctl -- add-bond br0 bond0 p0 p1 \
          -- set interface p0 type=patch options:peer=p1 \
          -- set interface p1 type=patch options:peer=p0

Bug #4527.
Reported-by: Krishna Miriyala <krishna at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/netdev-vport.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Open vSwitch




More information about the git mailing list